Add test for LikeExpression.setEscape and LikeExpression.getStringExpression#1568
Add test for LikeExpression.setEscape and LikeExpression.getStringExpression#1568wumpz merged 2 commits intoJSQLParser:masterfrom
Conversation
|
What problem exactly will this PR solve and why should your test become part of the Test Suite please? The result isn't meaningful or valid. |
|
Hey 🙂 This tests the methods It is based on / inspired by the test Would it be better to include a more meaninigful query instead of the 'default' Do you find it relevant to test |
|
Adding test coverage is definitely good -- when the tests are meaningful and assert something. Test without purpose are considered harmful, since they pretend coverage where no insurance is provided. Better craft an actual valid Expression using the |
|
Thank you for your input and patience 🙂 I've changed the expression to match all records with names that start with letter ’J’ and have the ’_’ character in them: What do you think? |
|
Thank you, looks much better now and I would like to recommend to accept your PR. |
Hey 😊
I want to contribute a test.
Curious to hear what you think!
(I wrote this test as part of a research study at TU Delft. Find out more)